Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for overview of alert profiles page #2741

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Nov 15, 2023

Another PR to improve testing of the alert profile views.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54449ed) 55.46% compared to head (ba90a00) 55.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
+ Coverage   55.46%   55.51%   +0.05%     
==========================================
  Files         567      567              
  Lines       41172    41172              
==========================================
+ Hits        22837    22858      +21     
+ Misses      18335    18314      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 15, 2023

Test results

     12 files       12 suites   11m 33s ⏱️
3 258 tests 3 258 ✔️ 0 💤 0
9 249 runs  9 249 ✔️ 0 💤 0

Results for commit ba90a00.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland force-pushed the tests/alertprofiles/add-overview-test branch from c079eb6 to ba90a00 Compare November 17, 2023 07:10
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johannaengland johannaengland merged commit 7d22c71 into Uninett:master Nov 17, 2023
13 checks passed
@johannaengland johannaengland deleted the tests/alertprofiles/add-overview-test branch November 17, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants