Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to our GitHub discussion forums #2746

Merged
merged 1 commit into from Nov 17, 2023

Conversation

lunkwill42
Copy link
Member

We enabled GitHub forums for NAV a while back. They should be mentioned in the docs as a place to get help.

@lunkwill42 lunkwill42 added the documentation Related to documentation of NAV label Nov 16, 2023
@lunkwill42 lunkwill42 self-assigned this Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d26ed2) 55.46% compared to head (245985f) 55.46%.
Report is 6 commits behind head on master.

❗ Current head 245985f differs from pull request most recent head 57b47a3. Consider uploading reports for the commit 57b47a3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2746   +/-   ##
=======================================
  Coverage   55.46%   55.46%           
=======================================
  Files         567      567           
  Lines       41172    41172           
=======================================
  Hits        22837    22837           
  Misses      18335    18335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 45s ⏱️
3 256 tests 3 256 ✔️ 0 💤 0
9 243 runs  9 243 ✔️ 0 💤 0

Results for commit 245985f.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more of a style thing, but doesn't GitHub discussion forum make more sense than GitHub discussion forums?

We enabled GitHub forums for NAV a while back.  They should be mentioned
in the docs as a place to get help.
@lunkwill42
Copy link
Member Author

Maybe more of a style thing, but doesn't GitHub discussion forum make more sense than GitHub discussion forums?

Sure, but we love ourselves some nitpicks :)

Updated.

@lunkwill42 lunkwill42 merged commit 9dbc1d0 into Uninett:master Nov 17, 2023
7 of 8 checks passed
@lunkwill42 lunkwill42 deleted the doc/discussionforums branch November 17, 2023 09:31
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation of NAV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants