Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function snmp_parameter_factory #2753

Conversation

lunkwill42
Copy link
Member

This has been replaced by SNMPParameters.factory() and no callers are left.

This has been replaced by SNMPParameters.factory() and no callers are
left.
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48b4393) 55.57% compared to head (be6c58e) 55.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2753   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         567      567           
  Lines       41247    41245    -2     
=======================================
- Hits        22922    22921    -1     
+ Misses      18325    18324    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 35s ⏱️
3 268 tests 3 268 ✔️ 0 💤 0
9 279 runs  9 279 ✔️ 0 💤 0

Results for commit be6c58e.

@lunkwill42 lunkwill42 merged commit 4219a2a into Uninett:master Nov 21, 2023
13 checks passed
@lunkwill42 lunkwill42 deleted the clean/remove-unused-snmp-parameter-factory branch November 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants