Constrain ciscoconfparse on Python 3.7
#2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscoconfparse 1.8 does not work on Python 3.7. This adds a new constraints.txt file to ensure ciscoconfparse is constrained to < 1.8 under Python 3.7.
Several versions of ciscoconfparse 1.7 were yanked from PyPI due to missing dependencies. These have since been fixed. However, this constraint ensured that our test suite did not catch issues with ciscoconfparse 1.8 under Python 3.7. Removing the now unnecessary constraint.
|
SonarCloud Quality Gate failed.
|
hmpf
approved these changes
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #2771 +/- ##
==========================================
- Coverage 56.20% 56.20% -0.01%
==========================================
Files 567 567
Lines 41277 41277
==========================================
- Hits 23201 23200 -1
- Misses 18076 18077 +1 ☔ View full report in Codecov by Sentry. |
|
No idea what this is all about, none of this code was touched or involved in this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
constraints.txtfile where constraints on third party libraries can be specified.The initial version of this file constrains
ciscoconfparsespecifically on Python versions less than 3.8 to be a version below the failing 1.8 version.Documentation and build scripts are updated to include the new constraints file.
An existing "constraint" existed in the test environment requirements, because early
ciscoconfparsereleases in the 1.7 series did not declare dependencies (these versions were later yanked from PyPI). This constraint is likely why our test suite never discovered this problem on Python 3.7.Closes #2770