Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Content-Security-Policy #2822

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Feb 22, 2024

Closes #2818

Locally, it cannot run integration tests at all because urllib.error.URLError: <urlopen error [Errno 99] Cannot assign requested address>.

I want to see what github actions does.

@hmpf hmpf self-assigned this Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

Test results

       9 files         9 suites   8m 8s ⏱️
3 320 tests 3 316 ✔️ 0 💤 4
7 180 runs  7 176 ✔️ 0 💤 4

For more details on these failures, see this check.

Results for commit 32459e0.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the csp-support branch 4 times, most recently from f07f6ff to 03b2873 Compare February 28, 2024 09:50
@hmpf hmpf force-pushed the csp-support branch 2 times, most recently from c623826 to faa54e2 Compare February 28, 2024 13:22
@hmpf
Copy link
Contributor Author

hmpf commented Feb 29, 2024

In github actions, some functional tests fail.

  • FAILED tests/functional/geomap_test.py::test_geomap_loaded - AssertionError: ...
  • FAILED tests/functional/navbar_test.py::test_simple_ip_search_should_return_result
  • FAILED tests/functional/status_test.py::test_panel_should_toggle_when_clicked
  • FAILED tests/functional/status_test.py::test_remember_last_panel_state - sele...

@hmpf
Copy link
Contributor Author

hmpf commented Mar 7, 2024

I'm starting to wonder if all of this is better to do in the external webserver, since we need it both for NAV and for the non-NAV code.

Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSP allow same domain by default, configurable
1 participant