Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an adaptation to Pythons older than 3.7 #2840

Merged
merged 1 commit into from Feb 29, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Feb 29, 2024

No description provided.

@hmpf hmpf added the upgrade label Feb 29, 2024
@hmpf hmpf self-assigned this Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf marked this pull request as ready for review February 29, 2024 07:13
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.11%. Comparing base (cbdf13f) to head (13b1b89).
Report is 2 commits behind head on master.

Files Patch % Lines
python/nav/web/auth/remote_user.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2840   +/-   ##
=======================================
  Coverage   57.10%   57.11%           
=======================================
  Files         567      567           
  Lines       41278    41268   -10     
=======================================
- Hits        23571    23569    -2     
+ Misses      17707    17699    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test results

     12 files       12 suites   11m 44s ⏱️
3 303 tests 3 303 ✔️ 0 💤 0
9 384 runs  9 384 ✔️ 0 💤 0

Results for commit 13b1b89.

@hmpf hmpf changed the title Remove an adaption to Pythons older than 3.7 Remove an adaptation to Pythons older than 3.7 Feb 29, 2024
@lunkwill42 lunkwill42 mentioned this pull request Feb 29, 2024
3 tasks
@hmpf hmpf merged commit 0fe59ef into Uninett:master Feb 29, 2024
12 checks passed
@hmpf hmpf deleted the remoteuser-python37 branch February 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants