Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define FakeSession as a fixture #2842

Merged
merged 2 commits into from Feb 29, 2024

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Feb 29, 2024

Fixes #2841

Only reasonable way to share code like this between files is via a fixture afaik. Could have defined the fixture to return the class itself and not an instance of the class, but that felt weird. This should work fine

@stveit stveit marked this pull request as ready for review February 29, 2024 09:39
@stveit stveit force-pushed the tests.define_fakesession_once branch from 2691d50 to 14b535c Compare February 29, 2024 09:43
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (dff1b0c) to head (504ae38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2842   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files         567      567           
  Lines       41275    41268    -7     
=======================================
- Hits        23585    23584    -1     
+ Misses      17690    17684    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stveit stveit self-assigned this Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stveit stveit merged commit 106ef20 into Uninett:master Feb 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define FakeSession once
2 participants