Remove imports/adjustments to make NAV run on Python<3.9/Django<3.2 #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2903 +/- ##
=======================================
Coverage 56.35% 56.36%
=======================================
Files 603 601 -2
Lines 43862 43827 -35
Branches 48 48
=======================================
- Hits 24719 24702 -17
+ Misses 19131 19113 -18
Partials 12 12 ☔ View full report in Codecov by Sentry. |
We don't need the adapter for different Django versions anymore since Django 1.8
This has been superfluous since dropping Django 2.2
johannaengland
force-pushed
the
drop-python-37-code-changes
branch
from
5f65059
to
f1bab55
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part to #2790. Closes #2839.
Improvements due to changes in Python 3.8/3.9 will come in a separate PR.