Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting logger name to empty string if root #2912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

Dependent on #2901.

Since Python 3.9 getLogger('root') also returns the root logger: python/cpython#15077

Mentioned also here: https://docs.python.org/3/whatsnew/3.9.html#changes-in-the-python-api

@johannaengland johannaengland self-assigned this May 14, 2024
@johannaengland johannaengland requested review from hmpf, lunkwill42 and stveit and removed request for hmpf and lunkwill42 May 14, 2024 12:12
Copy link

Test results

       9 files         9 suites   7m 46s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0
6 379 runs  6 379 ✔️ 0 💤 0

Results for commit 6badf05.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.35%. Comparing base (b8d6d52) to head (0536ed0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2912   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files         603      603           
  Lines       43862    43858    -4     
  Branches       48       48           
=======================================
- Hits        24719    24718    -1     
+ Misses      19131    19128    -3     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since Python 3.9 getLogger('root') also returns the root logger
@johannaengland johannaengland force-pushed the getting-root-logger-argument-root branch from 6badf05 to 0536ed0 Compare July 3, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant