PostgreSql adapter

[agborkowski]

PostgreSql adapter

[masom]

Awesome, beat me to it.

[mariuswilms]

How much do MySql and PostgreSql adapters actually have in common? Could they subclass a common base class?
We probably need a rdbms base class. Other rdbms adapters are already in sight (oracle, drizzle?).

Also what will the policy be with adapters we cannot (regularly) test ourselves?

[mariuswilms]

First of all thanks @agborkowski and @zdrap for your hard work!

I've just reviewed the attached patches a bit more and have a few tips for improvement.

• Commit messages could be more clearer (and more verbose where it makes sense).
• Commit messages should be using English.
• Try to merge commits where possible i.e. the ones related to tests.
• When adding initial functionality you most often need just one solid commit. You could add the adapter in one commit and the tests for it in another.
• Try to leave out noise in your patches i.e. [bf0e4dc]. I guess this wasn't intentional and that github doesn't make it clear with the pull request system.

[agborkowski]

@DavidPersson we're start using lithium, git and github in our inc. so pls. forgive some mistake.

[mariuswilms]

@agborkowski Let me rephrase that as it maybe came around wrong: It is really great and appreciated that you're putting time into improving Lithium. I took the pull request as a chance to make the submitted patches a cool and even better thing. So no worries.

My first comment is much more of a side note to how adapter additions should be handled in general, directed at the team.

[agborkowski]

@DavidPersson of course i'm sure understand You, its good point (this commit) to start make a good pieces of lithium by community !

anyway sombody know (mysql_unbuffered_query) similar function in pgsql ?

[nateabele]

@agborkowski The PostgreSQL driver for PHP does not support unbuffered queries. That's okay though, your adapter does not need to support every feature of other adapters. I'll try to test it and merge in your patches this weekend. Thanks again for the awesome work!

[nateabele]

This pull request has been merged to the postgres development branch, which will be merged into the next release. Any further work should be branched from there. Thanks again for your efforts.

[xorock]

I just can't understand one thing. Lithium is strictly connected to PHP 5.3. Why then, adapters are not written extending PDO?

[agborkowski]

i think low level adapter are faster than create next abstract layer over PDO

[daschl]

@xorock @agborkowski We are currently in the process of moving our datasources over to PDO. MySQL has already been moved, sqlite3 is under way and postgres is also planned.