When there are only two simple parameters, routing fails...

[al-the-x]

I added a test to lithium/tests/cases/net/http/RouteTest.php to reflect a route that we were attempting to use in our project that was failing to route. My guess is that the regex in Route::compile():366 is incorrectly seeing the second pattern as the regex part of the first pattern. I made that capture pattern lazy and got greens. Please review. Thanks,

David @ OrlandoPHP.org

[al-the-x]

BTW, I rebased to the current (as of today) master after making that pull request, which of course changed my commits. If github doesn't know what to do with it, I'll reopen my pull request.

[mehlah]

This is related to issue #157 #154
and solve it !
I was completely on the wrong track with my solution

more tests cases here mehlah@33089d4

[mehlah]

Is there a regex master who can explain why this happens and what's exactly going on ? :-)

[ifunk]

@mehlah http://www.exampledepot.com/egs/java.util.regex/Greedy.html

[mehlah]

@ifunk: sure, I understand the role played by the ? in the regex, but how come increasing pcre backtrack_limit make it as well ?
That's the part I don't get :-)

[al-the-x]

Since you essentially used the code from this pull request in your own commit verbatim, wouldn't it have been easier just to accept the pull request? Or am I missing some contributor politics here...?

[nateabele]

Sorry, it was mostly laziness. The fix itself was the same, but I ended up completely rewriting the test to be exhaustive in terms of the cases it covers. Anyway, I couldn't remember the series of commands to amend someone else's work but still maintain attribution.

[al-the-x]

See git commit --amend [commit-ish] for future reference... ;)

[nateabele]

Heh, nice. Thanks.