Fix some issues of lithium\util\Collection. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $data = array( | ||
| 'Hello', |
There was a problem hiding this comment.
I don't follow why you changed the test here. Wouldn't it be better to have both?
There was a problem hiding this comment.
Yeah a bug occurs when you try to unset the first element in a foreach but you're right, it's better to keep both test.
|
I refactored the tests to be more consistent with older tests |
| @@ -32,7 +32,7 @@ | |||
| * | |||
| * $coll = new Collection(array('data' => array(0, 1, 2, 3, 4))); | |||
| * | |||
| * $coll->first(); // 1 (the first non-empty value) | |||
There was a problem hiding this comment.
Just to clarify, the change here points out a BC break in first()?
There was a problem hiding this comment.
Well I just found that it works like that so i decide to update the docblock but it's not a direct consequence of this PR. The BC break must have happened in a previous PR.
nateabele
added a commit
that referenced
this pull request
May 23, 2012
Fix some issues of lithium\util\Collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving some bugs on
unset()and changing theArrayAccess::offsetExist()behavior.ArrayAccess::offsetExist()should indicate if an offset exists and imo it would work asarray_key_exists().ArrayAccess::offsetExist()is indeed a magic method called onisset()but imo it's an inconsistency in the PHP language.