Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor collections and results classes for better consistency and fix some issues. #540

Merged
merged 2 commits into from Jun 15, 2012

Conversation

jails
Copy link
Contributor

@jails jails commented Jun 15, 2012

Squash #477, Fix typos, rebase on last commit (data branch), rewrite Sqlite3 on top of PDO

Summary :

Warning BC break :
DocumentArray and DocumentSet are here merged into the DocumentSet class

Should i add an empty DocumentArray class extending DocumentSet for keeping backward compatibility ?

nateabele added a commit that referenced this pull request Jun 15, 2012
Refactor collections and results classes for better consistency and fix some issues.
@nateabele nateabele merged commit e3bb0b3 into UnionOfRAD:data Jun 15, 2012
@nateabele
Copy link
Member

I'm guessing this replaces your previous gigantic pull request? ;-)

@jails
Copy link
Contributor Author

jails commented Jun 15, 2012

Indeed ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants