Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #687, use a more standard syntax for SQL LIMIT clauses. #727

Merged
merged 1 commit into from Dec 11, 2012
Merged

Fix #687, use a more standard syntax for SQL LIMIT clauses. #727

merged 1 commit into from Dec 11, 2012

Conversation

jails
Copy link
Contributor

@jails jails commented Dec 11, 2012

Looks like PostgreSQL doesn't support the: LIMIT <skip>, <count> format.

@nateabele
Copy link
Member

What about MySQL?

@jails
Copy link
Contributor Author

jails commented Dec 11, 2012

MySQL support both syntax, but the doc shows they are all supporting the LIMIT <count> OFFSET <skip> syntax:
http://dev.mysql.com/doc/refman/5.0/en/select.html
http://www.postgresql.org/docs/7.3/static/queries-limit.html
http://sqlite.org/syntaxdiagrams.html#select-stmt

@jails
Copy link
Contributor Author

jails commented Dec 11, 2012

You Wrong Travis ! It pass !!!

@nateabele
Copy link
Member

Haha.

nateabele added a commit that referenced this pull request Dec 11, 2012
@nateabele
Merge pull request #727 from jails/pr58
7a33bc6 
Fix #687, use a more standard syntax for SQL `LIMIT` clauses.
@nateabele nateabele merged commit 7a33bc6 into UnionOfRAD:dev Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jails @nateabele