Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAL unit parsing is incorrect #16

Open
pete-farlow opened this issue Feb 15, 2019 · 1 comment
Open

NAL unit parsing is incorrect #16

pete-farlow opened this issue Feb 15, 2019 · 1 comment

Comments

@pete-farlow
Copy link

pete-farlow commented Feb 15, 2019

The BDInfo source code does not account for emulation prevention bytes at all, it seems you're not aware of those.
Therefore the results are pretty random.
With AVC the tool often gets lucky, because the respective nal units don't require emulation prevention all that much, but with HEVC it's totally hit and miss.

I saw a few workarounds in the code that sort of work around this bug, which can only work under certain conditions.

Anyway - after I fixed the code to include emulation prevention awareness and removed these workarounds, output was 100% reliable.

Please search the AVC and/or HEVC specs for "emulation prevention" - it's the same scheme in both cases.

@UniqProject
Copy link
Owner

Busy testing the changes.

UniqProject added a commit that referenced this issue Dec 5, 2020
(make stream parser aware of the emulation prevention bytes)
Addresses #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants