Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃悰 configuration file wasn't detecting changes properly #244

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

MaethorNaur
Copy link
Collaborator

When the configuration file was the only change, it wasn't triggering
any file changes detection

Refs: #238

When the configuration file was the only change, it wasn't triggering
any file changes detection

Refs: #238
@MaethorNaur MaethorNaur added bug Something isn't working Backend labels Oct 19, 2020
@MaethorNaur MaethorNaur added this to the v1.0.0 milestone Oct 19, 2020
@MaethorNaur MaethorNaur self-assigned this Oct 19, 2020
@MaethorNaur MaethorNaur added this to In Progress in UnisonUI via automation Oct 19, 2020
@MaethorNaur MaethorNaur linked an issue Oct 19, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #244 into master will increase coverage by 0.42%.
The diff coverage is 92.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   75.10%   75.53%   +0.42%     
==========================================
  Files          54       55       +1     
  Lines        1137     1165      +28     
  Branches       14       19       +5     
==========================================
+ Hits          854      880      +26     
- Misses        283      285       +2     
Impacted Files Coverage 螖
...ore/src/main/scala/tech/unisonui/Concurrency.scala 100.00% <酶> (酶)
...e/src/main/scala/tech/unisonui/Configuration.scala 100.00% <酶> (酶)
...ore/src/main/scala/tech/unisonui/grpc/Client.scala 91.66% <酶> (酶)
...src/main/scala/tech/unisonui/grpc/Marshaller.scala 100.00% <酶> (酶)
...in/scala/tech/unisonui/grpc/ReflectionClient.scala 95.91% <酶> (酶)
...re/src/main/scala/tech/unisonui/models/Event.scala 100.00% <酶> (酶)
...src/main/scala/tech/unisonui/models/Metadata.scala 100.00% <酶> (酶)
.../src/main/scala/tech/unisonui/models/Service.scala 66.66% <酶> (酶)
...cala/tech/unisonui/protobuf/ProtobufCompiler.scala 0.00% <0.00%> (酶)
...ain/scala/tech/unisonui/protobuf/data/Schema.scala 97.26% <酶> (酶)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1e3cad4...c428cc1. Read the comment docs.

@MaethorNaur MaethorNaur merged commit 17abb1b into master Oct 19, 2020
UnisonUI automation moved this from In Progress to Done Oct 19, 2020
@MaethorNaur MaethorNaur deleted the git-provider-config-file branch October 19, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working
Projects
UnisonUI
  
Done
Development

Successfully merging this pull request may close these issues.

Git provider doesn't handle changes properly
1 participant