feat: reject both input and output fees #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids a double-fee case from protocol fee controller
marktoda
force-pushed
the
reject-input-and-output-fees
branch
from
150d28c
to
1d0a95c
Compare
zhongeric
reviewed
Apr 24, 2024
| @@ -67,13 +71,17 @@ abstract contract ProtocolFees is Owned { | |||
| for (uint256 j = 0; j < outputsLength; j++) { | |||
| OutputToken memory output = order.outputs[j]; | |||
| if (output.token == feeOutput.token) { | |||
| if (inputFeeTaken) revert InputAndOutputFees(); | |||
There was a problem hiding this comment.
maybe im misreading but this code will never be true since inputFeeTaken is assigned after this?
There was a problem hiding this comment.
Oh, it's inside the outside loop. basically:
for every fee output added:
- is it a fee-on-output? (loop thru all outputs to check)
- is it a fee-on-input?
and this is just disallowing both, so placement inside the outer loop doesnt matter
zhongeric
approved these changes
Apr 25, 2024
| @@ -67,13 +71,17 @@ abstract contract ProtocolFees is Owned { | |||
| for (uint256 j = 0; j < outputsLength; j++) { | |||
| OutputToken memory output = order.outputs[j]; | |||
| if (output.token == feeOutput.token) { | |||
| if (inputFeeTaken) revert InputAndOutputFees(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids a double-fee case from protocol fee controller