Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: import @ethersproject directly to enforce modularization #2424

Merged
merged 4 commits into from Sep 24, 2021
Merged

perf: import @ethersproject directly to enforce modularization #2424

merged 4 commits into from Sep 24, 2021

Conversation

zzmp
Copy link
Member

@zzmp zzmp commented Sep 22, 2021

No description provided.

@vercel
Copy link

vercel bot commented Sep 22, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/interface/7f7WtTsiDEbCDT3YkmYrqD8GrTAH
✅ Preview: https://interface-git-perf-ethers-imports-uniswap.vercel.app

@zzmp
Copy link
Member Author

zzmp commented Sep 23, 2021

The entire ethers package is also brought in as a dependency to @davatar/react, which should be resolved by metaphor-xyz/davatar-helpers#4. This commit will be ineffective without an update to @davatar/react.

NoahZinsmeister
NoahZinsmeister approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@NoahZinsmeister NoahZinsmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will be nice once we get the @davatar update in

@zzmp
Copy link
Member Author

zzmp commented Sep 24, 2021

Waiting to merge this until @davatar/react updates, so that the version bump can be included in this PR.

@zzmp zzmp merged commit 1fcbd2d into main Sep 24, 2021
@zzmp zzmp deleted the perf-ethers-imports branch September 24, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahZinsmeister NoahZinsmeister NoahZinsmeister approved these changes

@JFrankfurt JFrankfurt Awaiting requested review from JFrankfurt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zzmp @NoahZinsmeister