refactor: price chart utility functions #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 flaky test on run #14342 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Mini Portfolio account drawer > should not re-fetch balances when the account drawer is opened |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
cartcrom
force-pushed
the
chart_refactor_formatter
branch
from
e2399ca
to
68977ed
Compare
cartcrom
force-pushed
the
chart_refactor_utils
branch
from
5796a0f
to
3f788fe
Compare
cartcrom
force-pushed
the
chart_refactor_utils
branch
from
38948d8
to
7d9647c
Compare
cartcrom
force-pushed
the
chart_refactor_utils
branch
from
7d9647c
to
23afb89
Compare
cartcrom
requested review from
a team,
tinaszheng,
cbachmeier and
just-toby
just-toby
approved these changes
Sep 13, 2023
just-toby
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaks price chart utilities into utils file, improves performance of getPriceBounds and getNearestPricePoint, and improves readability / documentation.
QA (ie manual testing)