Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use bips base constant #7464

Merged
merged 2 commits into from Oct 13, 2023
Merged

refactor: use bips base constant #7464

merged 2 commits into from Oct 13, 2023

Conversation

cartcrom
Copy link
Contributor

Description

replaces hardcoded usage of 10000 as bips base w/ a constant

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 4:29pm

cartcrom
cartcrom commented Oct 13, 2023
View reviewed changes
src/constants/misc.ts
export const ONE_BIPS = new Percent(JSBI.BigInt(1), BIPS_BASE)

// used for warning states
export const ALLOWED_PRICE_IMPACT_LOW: Percent = new Percent(JSBI.BigInt(100), BIPS_BASE) // 1%
export const ALLOWED_PRICE_IMPACT_MEDIUM: Percent = new Percent(JSBI.BigInt(300), BIPS_BASE) // 3%
export const ALLOWED_PRICE_IMPACT_HIGH: Percent = new Percent(JSBI.BigInt(500), BIPS_BASE) // 5%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage of JSBI here seemed redundant

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited

Codecov Report

Merging #7464 (d26fe24) into main (ad1e2c6) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 61.53%.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.82% <61.53%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 13, 2023 •
edited

9 flaky tests on run #15014 ↗︎

0 118 0 0 Flakiness 9

Details:

refactor: use bips base constant
Project: Uniswap Interface Commit: d26fe245c4
Status: Passed Duration: 05:48 💡
Started: Oct 13, 2023 4:33 PM Ended: Oct 13, 2023 4:39 PM
Flakiness  swap/uniswapx.test.ts • 7 flaky tests • e2e

View Output Video

Test Artifacts
UniswapX Toggle > prompts opt-in if UniswapX is better Output Screenshots
UniswapX Orders > can swap exact-in trades using uniswapX Output Screenshots
UniswapX Orders > can swap exact-out trades using uniswapX Output Screenshots
UniswapX Eth Input > can swap using uniswapX with ETH as input Output Screenshots
UniswapX Eth Input > switches swap input to WETH after wrap Output Screenshots
UniswapX activity history > can view UniswapX order status progress in activity upon expiry Output Screenshots
UniswapX activity history > balances should refetch after uniswapx swap Output Screenshots
Flakiness  permit2.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Permit2 > prompts signature when existing permit approval is expired Output Screenshots
Flakiness  nfts.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Testing nfts > should navigate to and from the owned nfts page Output Screenshots

Review all test suite changes for PR #7464 ↗︎

@cartcrom cartcrom merged commit 7f597c0 into main Oct 13, 2023
25 checks passed
@cartcrom cartcrom deleted the bips_base branch October 13, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbspector mattbspector mattbspector approved these changes

@tinaszheng tinaszheng tinaszheng approved these changes

@just-toby just-toby just-toby approved these changes

@JackShort JackShort Awaiting requested review from JackShort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cartcrom @mattbspector @tinaszheng @just-toby