Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currency balance for search token #7471

Merged
merged 2 commits into from Oct 18, 2023
Merged

fix: currency balance for search token #7471

merged 2 commits into from Oct 18, 2023

Conversation

ksvat
Copy link
Contributor

@ksvat ksvat commented Oct 14, 2023

Description

fixes #7463

Screen capture

Before After
Screenshot 2023-10-13 at 9 45 09 PM Screenshot 2023-10-13 at 9 45 20 PM

Test plan

Reproducing the error

  1. Search for any token in token selector
  2. Observe infinite loading

@ksvat ksvat requested review from a team and natew October 14, 2023 05:14
@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:15pm

@zzmp
Copy link
Member

zzmp commented Oct 17, 2023

I think if I close and re-open the PR it may cause tests to run...

@zzmp zzmp closed this Oct 17, 2023
@zzmp zzmp reopened this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #7471 (6d38eac) into main (740db0f) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.75% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@just-toby just-toby merged commit 71d3661 into Uniswap:main Oct 18, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Balance doesn't load when searching in token selector
3 participants