Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update e2e tests after X rollout #7583

Merged
merged 1 commit into from Nov 14, 2023
Merged

test: update e2e tests after X rollout #7583

merged 1 commit into from Nov 14, 2023

Conversation

just-toby
Copy link
Contributor

Description

updates our e2e tests to enable unsiwapX by default since that's the behavior in prod now.

@just-toby just-toby requested review from kristiehuang, cartcrom and a team November 13, 2023 23:39
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 11:40pm

@just-toby just-toby changed the title test: updatea e2e tests after X rollout test: update e2e tests after X rollout Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #7583 (51b59be) into main (f2f59d5) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 43.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

cypress bot commented Nov 13, 2023

1 flaky test on run #15501 ↗︎

0 127 0 0 Flakiness 1

Details:

test: updatea e2e tests after X rollout
Project: Uniswap Interface Commit: 51b59be285
Status: Passed Duration: 04:09 💡
Started: Nov 13, 2023 11:43 PM Ended: Nov 13, 2023 11:47 PM
Flakiness  cypress/e2e/swap/errors.test.ts • 1 flaky test • e2e

View
Output

Test Artifacts
Swap errors > slippage failure Screenshots

Review all test suite changes for PR #7583 ↗︎

@just-toby just-toby merged commit 1feeaea into main Nov 14, 2023
29 checks passed
@just-toby just-toby deleted the feat/uniswapx-tests branch November 14, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants