Fix for Uniswap #2648: Sets price in price bar to match the execution price #7640
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the price in the price bar matched the execution price, not the price of 1 base, as shown below.
Above we see 1 ETH = 20.2571 DAI, which is ~$20.27. Before, the price shown was the price of 1 ETH.
Also, on a side note, I experienced an issue while trying to run this locally. After cloning down the repo and running yarn install and yarn web start at the project's root, I got the below error:
I was able to X it out in the browser and continue working, but just a heads up.