routing-api simulation status change from string to enum #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jsy1218
commented
Jun 20, 2024
graphite-app
bot
requested review from
xrsv,
uni-guillaume,
cgkol,
mikeki and
a team
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/20/24)6 reviewers were added and 1 assignee was added to this PR based on 's automation. |
cgkol
approved these changes
Jun 20, 2024
jsy1218
deleted the
jsy1218/tenderly-simulation-status-from-string-to-enum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trading api team requested to change the simulation status type from string to enum.
we will still return the
simulationStatusresponse field as string, as tested in my local https://app.warp.dev/block/Z8Iu8aUYWn7F3hxXSIQh91.All e2e tests can pass https://app.warp.dev/block/pHRc3WeTfygM4wgYHEmHSP, indicating no change of the
simulationStatusresponse field string type.