feat(uniswapx-sdk): PriorityOrder type and builder #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (06/27/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
zhongeric
approved these changes
Jun 27, 2024
| const div = product.div(MPS); | ||
| return { | ||
| ...output, | ||
| amount: mod.eq(0) ? div : div.add(1), |
There was a problem hiding this comment.
do you need to do this rounding for the input as well? for round down
There was a problem hiding this comment.
I think BigNumber.div() rounds down by default
ConjunctiveNormalForm
changed the title
zhongeric
approved these changes
Jun 28, 2024
zhongeric
approved these changes
Jun 28, 2024
zhongeric
approved these changes
Jul 8, 2024
codyborn
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Summary of the change, motivation, and context]
Add PriorityOrder type and builder