feat: filter out zero value quotes #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
reviewed
Jul 6, 2023
zhongeric
commented
Jul 7, 2023
marktoda
reviewed
Jul 7, 2023
rileydcampbell
approved these changes
Jul 10, 2023
| // return either the rfq quote or a synthetic quote from the classic dependency | ||
| async resolve(dependencies: QuoteByKey): Promise<Quote | null> { | ||
| const quote = await this.resolveHandler(dependencies); | ||
| if (!quote || (quote as DutchQuote).amountOutEnd.eq(0)) return null; |
There was a problem hiding this comment.
Suggested change
| if (!quote || (quote as DutchQuote).amountOutEnd.eq(0)) return null; | |
| if (!quote || (quote as DutchQuote).amountOutEnd.lte(0)) return null; |
maybe overkill ?
| const quote = await context.resolve({ | ||
| [QUOTE_REQUEST_DL.key()]: rfqQuote, | ||
| }); | ||
| expect(quote).toMatchObject(rfqQuote); | ||
| expect((quote?.toJSON() as DutchQuoteDataJSON).orderInfo.exclusiveFiller).toEqual(filler); | ||
| }); | ||
|
|
||
| it('returns null if quotes have 0 amountOut', async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.