Add synthetics based on token list #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 92b262a.
rileydcampbell
force-pushed
the
add_synthetics_based_on_token_list
branch
from
dcb2c92
to
6dfa75f
Compare
zhongeric
reviewed
Jul 14, 2023
rileydcampbell
force-pushed
the
add_synthetics_based_on_token_list
branch
from
34cd537
to
4a1d688
Compare
zhongeric
approved these changes
Jul 14, 2023
rileydcampbell
force-pushed
the
add_synthetics_based_on_token_list
branch
2 times, most recently
from
84ec6ae
to
c21b98e
Compare
zhongeric
reviewed
Jul 14, 2023
willpote
reviewed
Jul 14, 2023
rileydcampbell
force-pushed
the
add_synthetics_based_on_token_list
branch
from
c21b98e
to
23a5741
Compare
willpote
reviewed
Jul 14, 2023
rileydcampbell
force-pushed
the
add_synthetics_based_on_token_list
branch
from
e1dc268
to
4ee6202
Compare
|
lets make sure to make synthetic quotes the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Returns
nullwhen creating a synthetic quote if the tokens are not on the eligible list.