Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move deadline into separate checkDeadline(uint256 deadline) call to make it optional #3

Closed
moodysalem opened this issue Aug 12, 2021 · 0 comments
Closed

move deadline into separate checkDeadline(uint256 deadline) call to make it optional #3

moodysalem opened this issue Aug 12, 2021 · 0 comments

Comments

@moodysalem
Copy link
Contributor

this way calls we always want to succeed (like the first add liquidity for a pool) don't need to fail or can fail fast

also removes duplicate deadline checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move deadline out Uniswap/swap-router-contracts
2 participants
@NoahZinsmeister @moodysalem