feat: quote both sides of the trade #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit requests a quote from both sides of every trade
marktoda
force-pushed
the
quote-both-sides
branch
from
397ec79
to
c561ddf
Compare
ConjunctiveNormalForm
approved these changes
Jul 5, 2023
| // switch tokenIn/tokenOut | ||
| tokenIn: getAddress(this.tokenOut), | ||
| tokenOut: getAddress(this.tokenIn), | ||
| amount: this.amount.toString(), |
There was a problem hiding this comment.
not sure if it matter,s but if we simply re-use the amount, it should be possible for MMs to guess the side of real quote in some cases? for ETH<>USDC, amount=1 almost certainly implies direction is ETH -> USDC right?
There was a problem hiding this comment.
since its exactOutput the other way, its just as viable of a trade as exactIn with tokenIn/out flipped, no?
willpote
pushed a commit
that referenced
this pull request
Jul 13, 2023
feat: quote both sides of the trade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit requests a quote from both sides of every trade