feat: add api level alarms and some rfq overall alarms #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
commented
Jul 15, 2023
bin/stacks/api-stack.ts
Outdated
| const rfqOverallNonQuoteRateAlarmSev2 = new aws_cloudwatch.Alarm(this, 'UniswapXParameterizationAPI-SEV2-RFQ-NonQuoteRate', { | ||
| alarmName: 'UniswapXParameterizationAPI-SEV2-RFQ-NonQuoteRate', | ||
| metric: rfqOverallNonQuoteMetric, | ||
| threshold: 50, |
There was a problem hiding this comment.
Do we think this is too high / low?
There was a problem hiding this comment.
Hmm, I don't think we should SEV2 on anything depending on MMs since they are free and within their right to not quote if they want. And not much we can do quickly if we get paged about this.
Maybe we just do SEV3 so we are notified and can ping them during business hours?
willpote
reviewed
Jul 16, 2023
willpote
reviewed
Jul 16, 2023
willpote
reviewed
Jul 16, 2023
willpote
reviewed
Jul 16, 2023
rileydcampbell
approved these changes
Jul 16, 2023
willpote
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.