Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

feat: update sdk-core version #78

Closed
wants to merge 1 commit into from
Closed

Conversation

just-toby
Copy link

@just-toby just-toby commented Jul 17, 2023

get the latest version of sdk-core

sdk-core had a major version bump recently, so this is needed to deduplicate sdk-core and avoid type conflicts as i upgrade it and other packages in interface

the breaking changes in sdk-core were implemented here

mainly that the SupportedChainId enum is replaced with a ChainId enum.

i don't see any usage of this enum in this SDK, but i'm happy to verify this change in any way the owners recommend, including automated and manual tests

@tinaszheng
Copy link
Contributor

y tho

@just-toby
Copy link
Author

y tho

@tinaszheng sdk-core had a major version bump recently, so this is needed to deduplicate sdk-core and avoid type conflicts as i upgrade it and other packages in interface

@cbachmeier
Copy link

Bump @rileydcampbell @tinaszheng @marktoda this update is blocking our ability to patch the interface for the avax/bnb bug

@marktoda
Copy link
Collaborator

This is a pretty big change to a major version, can you help enumerate what the breaking changes are so we can be sure it won't break downstream dependents?

@just-toby
Copy link
Author

This is a pretty big change to a major version, can you help enumerate what the breaking changes are so we can be sure it won't break downstream dependents?

@marktoda @cbachmeier updated the description - the only breaking change should be an enum renamed from SupportedChainId to ChainId. can we approve and run the test suite ?

@cbachmeier
Copy link

cbachmeier commented Jul 18, 2023

ChainId/SupportedChainId isn't used in this repo so no further change was required. All tests pass locally.

@marktoda marktoda closed this Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants