Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update throttling #275

Merged
merged 2 commits into from
Jul 16, 2023
Merged

update throttling #275

merged 2 commits into from
Jul 16, 2023

Conversation

willpote
Copy link
Contributor

@willpote willpote commented Jul 16, 2023

Changing ip rate limiting to be per endpoint, and dropping numbers especially for post order:

Previously we allowed 4 TPS across all endpoints, so this actually allows a higher TPS in aggregate, but puts more restrictions on POST order

Let me know if we feel this is too low for anything:

POST order: 100 per 5 mins, i.e. 1 every 3 seconds
GET orders: 900 per 5 mins, i.e. 3 TPS
GET nonce: 150 per 5 mins, i.e. 1 every 2 seconds
GET docs: 100 per 5 mins, i.e. 1 every 3 seconds

Also the first rule, which is first priority, allows requests with api key through with no throttle

@rileydcampbell
Copy link
Contributor

rileydcampbell commented Jul 16, 2023

The only one I'd change is the get orders bc we bumped that specifically for market makers who asked to be able to query more frequently during burst testing.

althought I guess 3 tps is still pretty reasonable considering there's only a block every 12 secs.

@willpote willpote merged commit 2a1d3e4 into main Jul 16, 2023
2 checks passed
@willpote willpote deleted the throttling-tweaks branch July 16, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants