Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback for payment #83

Merged
merged 65 commits into from
Dec 15, 2020
Merged

callback for payment #83

merged 65 commits into from
Dec 15, 2020

Conversation

moodysalem
Copy link
Contributor

@moodysalem moodysalem commented Oct 21, 2020

fixes #45

@moodysalem moodysalem changed the title initial work callback for payment Oct 21, 2020
# Conflicts:
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
# Conflicts:
#	contracts/UniswapV3Pair.sol
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
# Conflicts:
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
# Conflicts:
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
# Conflicts:
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
@moodysalem moodysalem marked this pull request as ready for review October 28, 2020 03:21
# Conflicts:
#	test/UniswapV3Pair.spec.ts
# Conflicts:
#	contracts/UniswapV3Pair.sol
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/shared/fixtures.ts
# Conflicts:
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
# Conflicts:
#	contracts/UniswapV3Pair.sol
#	contracts/test/TestUniswapV3Callee.sol
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
# Conflicts:
#	test/UniswapV3Pair.spec.ts
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
#	test/shared/utilities.ts
# Conflicts:
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
# Conflicts:
#	test/__snapshots__/UniswapV3Factory.spec.ts.snap
#	test/__snapshots__/UniswapV3Pair.spec.ts.snap
@moodysalem moodysalem marked this pull request as ready for review December 15, 2020 20:39
contracts/UniswapV3Pair.sol Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
contracts/UniswapV3Pair.sol Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
moodysalem and others added 8 commits December 15, 2020 15:52
contracts/UniswapV3Pair.sol Outdated Show resolved Hide resolved
@moodysalem moodysalem merged commit a9ddd58 into master Dec 15, 2020
@moodysalem moodysalem deleted the callback-pay branch December 15, 2020 22:36
0xrelapse pushed a commit to ferumlabs/uni-v3-core that referenced this pull request Mar 22, 2024
* add exact output check

* Fix code style issues with Prettier

* check exact output only with no price limit

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explore accepting user tokens via (callback + balance checks) instead of transferFrom
3 participants