NFT metadata: allow token0 numerator for certain pair ratios #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
changed the title
moodysalem
reviewed
Mar 31, 2021
moodysalem
reviewed
Mar 31, 2021
ewilz
commented
Mar 31, 2021
ewilz
commented
Apr 1, 2021
|
|
||
| function initialize(TokenRatioOrderPriority[] memory tokens) public initializer() { | ||
| for (uint256 i = 0; i < tokens.length; i++) { | ||
| tokenRatioPriority[tokens[i].token] = tokens[i].priority; |
There was a problem hiding this comment.
maybe should trigger an event for each token to have a record of which tokens were recorded...(helpful for making changes in the future)
moodysalem
approved these changes
Apr 2, 2021
| @@ -39,6 +55,7 @@ contract NonfungibleTokenPositionDescriptor is INonfungibleTokenPositionDescript | |||
| token1Symbol: SafeERC20Namer.tokenSymbol(token1), | |||
| token0Decimals: IERC20Metadata(token0).decimals(), | |||
| token1Decimals: IERC20Metadata(token1).decimals(), | |||
| hasToken0RatioNumerator: hasToken0RatioNumerator(token0, token1), | |||
There was a problem hiding this comment.
would it make more sense to name this something like flipRatio?
|
|
||
| exports[`SwapRouter gas tests #exactInput WETH9 -> 0 1`] = `111324`; | ||
| exports[`SwapRouter gas tests #exactInput WETH9 -> 0 1`] = `111179`; |
There was a problem hiding this comment.
mm..not sure..this file changed a bit in my last PR too. Happened on merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.