change add liq accounting #126
Conversation
snreynolds
force-pushed
the
sra/addLiq-accounting-updates
branch
from
220efb8
to
9edb230
Compare
contracts/libraries/Position.sol
Outdated
| function updateTokensOwed( | ||
| IBaseLiquidityManagement.Position storage position, | ||
| uint128 tokensOwed0, | ||
| uint128 tokensOwed1 | ||
| ) internal { | ||
| position.tokensOwed0 = tokensOwed0; | ||
| position.tokensOwed1 = tokensOwed1; | ||
| } |
There was a problem hiding this comment.
Ive been thinking about moving tokensOwed0/tokensOwed1 to a BalanceDelta type. iirc we almost always handle the two as a pair
maybe we're over-using the type, but i like it a lot haha
| (token0Owed) = FeeMath.getFeeOwed(feeGrowthInside0X128, position.feeGrowthInside0LastX128, position.liquidity); | ||
| (token1Owed) = FeeMath.getFeeOwed(feeGrowthInside1X128, position.feeGrowthInside1LastX128, position.liquidity); |
There was a problem hiding this comment.
any reason why to call this twice vs the getFeesOwed which returns both?
| BalanceDelta totalFeesAccrued, | ||
| BalanceDelta callerFeesAccrued, | ||
| PoolKey memory poolKey | ||
| ) internal returns (int128 callerDelta0, int128 callerDelta1) { |
There was a problem hiding this comment.
another candidate to move the return type to BalanceDelta ?
There was a problem hiding this comment.
directionally i think its getting there. makes a lot of sense to separately handle callerDeltas vs externalDeltas and remove PM currency transfers within the operation functions (_increaseLiq, _decreaseLiq, _collect). feels like we can reduce the round trips to PM
have picked up on some edge cases we might need to think thru:
| int128 delta0 = int128(manager.currencyDelta(address(this), currency0)); | ||
| int128 delta1 = int128(manager.currencyDelta(address(this), currency1)); |
There was a problem hiding this comment.
you can use CurrencyDeltas, which uses sparse extload to load both deltas in a single external call 😎
There was a problem hiding this comment.
can we move that function to TransientStateLibrary.sol ?
* additional increase liquidity tests * edge case of using cached fees for autocompound * wip
* fix some assertions * use BalanceDeltas for arithmetic * cleanest code in the game??? * additional cleaning * typo lol * autocompound gas benchmarks * autocompound excess credit gas benchmark * save 600 gas, cleaner code when moving caller delta to tokensOwed
Related Issue
Which issue does this pull request resolve?
Description of changes