Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isActive always false when activating with two injected providers (MetaMask and WalletLink) #406

Closed
earthtojake opened this issue Feb 6, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@earthtojake
Copy link

When there are two injected providers installed in the browser, e.g. MetaMask and WalletLink, and a user accepts one connection and rejects the other (common flow), the rejected connection throws an error and isActive state is not set to true for the accepted connector. This also blocks network switch requests which should appear after the connection is accepted. isActive state fixes itself on refresh. Can't find a reliable workaround.

This bug should probably be fixed with handling of multiple injected connectors, there's another issue here: #300

IMO multiple popups for injected connectors is pretty confusing UX and I don't think it should be the default.

The mustBeMetaMask flag for MM also doesn't fix the issue.

@earthtojake
Copy link
Author

Update: This is only a problem when you connect to MetaMask with WalletLink installed, but connecting to WalletLink with MetaMask installed works

@NoahZinsmeister
Copy link
Contributor

hm, i'm not sure it's worth trying to handle the case when a user has two extensions both injecting to window.ethereum - seems fairly uncommon and kind of an anti-pattern

@NoahZinsmeister NoahZinsmeister added the wontfix This will not be worked on label Feb 24, 2022
@Uniswap Uniswap locked and limited conversation to collaborators Mar 1, 2022
@NoahZinsmeister NoahZinsmeister converted this issue into discussion #445 Mar 1, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants