Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disabled token button text color should use correct colors #64

Merged
merged 2 commits into from
Jul 25, 2022
Merged

fix: disabled token button text color should use correct colors #64

merged 2 commits into from
Jul 25, 2022

Conversation

kristiehuang
Copy link
Contributor

before after
Screen Shot 2022-07-22 at 11 46 43 AM Screen Shot 2022-07-22 at 11 46 47 AM Screen Shot 2022-07-22 at 11 40 16 AM Screen Shot 2022-07-22 at 11 40 10 AM

@vercel
Copy link

vercel bot commented Jul 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 2:43PM (UTC)

cmcewen
cmcewen reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@cmcewen cmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so just reading this (and the last PR), think we have a bit of over-memo . generally it only makes sense to do it if the calculation is expensive, or if you're concerned about referential equality between objects you return. this has some good background: https://medium.com/swlh/should-you-use-usememo-in-react-a-benchmarked-analysis-159faf6609b7

i think both buttonBackgroundColor and contentColor should be un-memo'd

@kristiehuang kristiehuang marked this pull request as draft July 25, 2022 14:38
@kristiehuang kristiehuang marked this pull request as ready for review July 25, 2022 14:42
@vercel vercel bot temporarily deployed to Preview July 25, 2022 14:43 Inactive
@kristiehuang kristiehuang merged commit 92a0caa into main Jul 25, 2022
@kristiehuang kristiehuang deleted the fix/disabled-token-button-color branch July 25, 2022 20:38
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcewen cmcewen cmcewen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristiehuang @cmcewen