feat: onSuccess callback prop #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamueleA is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
SamueleA
changed the title
|
Thanks, @SamueleA! Because the SwapWidget is capable of performing multiple transactions (including token permits and approvals), I think that the onSuccess callback needs to convey some information on the successful transaction. Could you open an issue to discuss this (and link this PR!) so that we can iron that out and move forward with transaction callbacks? |
|
Made the onSuccess callback only trigger for SWAP and WRAP calls |
|
I'm not sure if we've documented it yet, but we now support onTxSuccess callbacks. |
tinaszheng
added a commit
that referenced
this pull request
Feb 25, 2023
chore: Rebase with main 2-8-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an onSuccess prop that triggers a callback once a swap is successful