STAR-977: Support for updates of PMT #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permobergedge
force-pushed
the
star-977-demuxer-improvements
branch
2 times, most recently
from
f9aabc2
to
16a8838
Compare
| @@ -203,6 +203,33 @@ PMTHeader::~PMTHeader() { | |||
|
|
|||
| } | |||
|
|
|||
| bool PMTHeader::operator==(const PMTHeader& other) { | |||
| if (mTableId != other.mTableId || | |||
| mInfos.size() != other.mInfos.size() || | |||
There was a problem hiding this comment.
Do you need to check the content of mInfos, not just the size?
permobergedge
force-pushed
the
star-977-demuxer-improvements
branch
from
16a8838
to
c3f91da
Compare
If the PMT changes, a new stream is added, start parsing that one as well. Previously the code locked on the first PMT in the stream.
permobergedge
force-pushed
the
star-977-demuxer-improvements
branch
from
c3f91da
to
b853652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PMT changes, a new stream is added, start parsing that one as well. Previously the code locked on the first PMT in the stream.