Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird optional dependency ikt #2092

Closed
kompot opened this issue Apr 14, 2016 · 3 comments
Closed

Weird optional dependency ikt #2092

kompot opened this issue Apr 14, 2016 · 3 comments

Comments

@kompot
Copy link

kompot commented Apr 14, 2016

In package.json I see the following

"optionalDependencies": {
  "ikt": "git+http://ikt.pm2.io/ikt.git#master"
},

I've checked out that repo and there's literally nothing but a single console.log.

I've found that by using npm's shrinkwrap that requires exact hashes (not master branch) to be set and it fails under certain circumstances.

Can that be dropped completely from package.json?

@n-johnson
Copy link

I've found that by using npm's shrinkwrap that requires exact hashes (not master branch) to be set and it fails under certain circumstances.

I have run into issues with this a number of times as well.

If you're adamant about collecting usage statistics in this manner and won't merge this PR, can you at least please update it to refer to the commit hash instead of branch?

"optionalDependencies": {
  "ikt": "git+http://ikt.pm2.io/ikt.git#3325a3e39a502418dc2e2e4bf21529cbbde96228"
},

Thanks!

@animedbz16
Copy link

Installing modules like this (outside of NPM) cause issues when behind
corporate firewalls.

We run a internal NPM caching server and when an NPM client attempts to
install modules such as this they fail.

NPM has published a blog post that relates specifically about this:
http://blog.npmjs.org/post/145724408060/dealing-with-problematic-dependencies-in-a

On Tue, Jun 14, 2016 at 6:05 PM Nathan Johnson notifications@github.com
wrote:

I've found that by using npm's shrinkwrap that requires exact hashes (not
master branch) to be set and it fails under certain circumstances.

I have run into issues with this a number of times as well.

If you're adamant about collecting usage statistics in this manner and
won't merge this PR, can you at least please update it to refer to the
commit hash instead of branch?

"optionalDependencies": {
"ikt": "git+http://ikt.pm2.io/ikt.git#3325a3e39a502418dc2e2e4bf21529cbbde96228"
},

Thanks!


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub
#2092 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACsR6MFf5gUegfbCydh4LesLCNMk6KlYks5qLyW-gaJpZM4IHnXQ
.

@Unitech
Copy link
Owner

Unitech commented Jul 6, 2016

git ikt dependency replaced with gkt tgz dependency

adcfa07

Available in PM2 V2:

$ npm install Unitech/pm2#development -g
$ pm2 update

If there is still a problem, please reopen issue

@Unitech Unitech closed this as completed Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants