Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging wrong "kill_timeout" into God#processIsDead #1961

Merged

Conversation

nskazki
Copy link

@nskazki nskazki commented Feb 21, 2016

I just experimented and observed that the "real" time allotted for the process shutdown does not match recorded in the log.

in my app.json "kill_timeout" = 300

{
  "name": "app",
  "script": ".",
  "kill_timeout": 300
}

but in the log I could see conflicting information:
(each PM2 Process with pid 10696 still not killed, retrying... = 100 ms)

PM2 Stopping app:app id:0
app-0 SIGINT
PM2 Process with pid 10696 still not killed, retrying...
PM2 Process with pid 10696 still not killed, retrying...
PM2 Process with pid 10696 still alive after 1600ms, sending it SIGKILL now...

so, pls accept my oneline fix :)

Unitech added a commit that referenced this pull request Mar 11, 2016
…eout

fix logging wrong "kill_timeout" into God#processIsDead
@Unitech Unitech merged commit 9d5cea1 into Unitech:development Mar 11, 2016
@Unitech
Copy link
Owner

Unitech commented Mar 11, 2016

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants