Improve upstart.tpl shell script syntax #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use spaces instead of tab for indent - Replace deprecated `command` with $(command) - Add missing quote to variable reference - Separate variable declaration and assign to avoid masking return values
|
|
inerc
pushed a commit
to inerc/pm2
that referenced
this pull request
Feb 11, 2020
Improve upstart.tpl shell script syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves
upstart.tplshell script syntax including:This is my first pull request to
pm2, please let me know if there is anything I missed that should be fixed, many thanks!