Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opts.namespace if it was passed in. Previously, it was ignored. #4791

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

sbleon
Copy link
Contributor

@sbleon sbleon commented Jul 21, 2020

Before:

$ pm2 start --namespace foo ecosystem.config.js
[PM2][WARN] Applications background_worker not running, starting...
[PM2] App [background_worker] launched (1 instances)
┌─────┬──────────────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name                 │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ background_worker    │ N/A         │ 0.0.1   │ fork    │ 86094    │ 0s     │ 0    │ online    │ 0%       │ 8.5mb    │ leon     │ enabled  │
└─────┴──────────────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘

After:

$ pm2 start --namespace foo ecosystem.config.js
[PM2][WARN] Applications background_worker not running, starting...
[PM2] App [background_worker] launched (1 instances)
┌─────┬──────────────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name                 │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ background_worker    │ foo         │ 0.0.1   │ fork    │ 86290    │ 0s     │ 0    │ online    │ 0%       │ 9.7mb    │ leon     │ enabled  │
└─────┴──────────────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no, but they're not passing on the development branch for me either
Fixed tickets #4778
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

Before:

```
$ pm2 start --namespace foo ecosystem.config.js
[PM2][WARN] Applications background_worker not running, starting...
[PM2] App [background_worker] launched (1 instances)
┌─────┬──────────────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name                 │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ background_worker    │ N/A         │ 0.0.1   │ fork    │ 86094    │ 0s     │ 0    │ online    │ 0%       │ 8.5mb    │ leon     │ enabled  │
└─────┴──────────────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
```

After:

```
$ pm2 start --namespace foo ecosystem.config.js
[PM2][WARN] Applications background_worker not running, starting...
[PM2] App [background_worker] launched (1 instances)
┌─────┬──────────────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name                 │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ background_worker    │ foo         │ 0.0.1   │ fork    │ 86290    │ 0s     │ 0    │ online    │ 0%       │ 9.7mb    │ leon     │ enabled  │
└─────┴──────────────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
```
@ghost
Copy link

ghost commented Jul 23, 2020

Anyone here that can look at this? :) Would be much appreciated for me who is waiting for the bug fix :D

@Unitech Unitech merged commit 3e9b398 into Unitech:development Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants