Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: filter_env not work when use {filter_env:true} #4889

Closed
wants to merge 1 commit into from

Conversation

bugkiwi
Copy link

@bugkiwi bugkiwi commented Oct 25, 2020

filter_env not work when use {filter_env:true}; {filter_env:somestring} should not change process.env

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2020

CLA assistant check
All committers have signed the CLA.

@bugkiwi bugkiwi changed the title Fix: filter env not work when use {filter_env:true}; {filter_env:some… Fix: filter env not work when use {filter_env:true} Oct 25, 2020
@bugkiwi bugkiwi changed the title Fix: filter env not work when use {filter_env:true} Fix: filter_env not work when use {filter_env:true} Oct 25, 2020
@mhassan1
Copy link

I was also bitten by this bug. It might be a good idea to open an issue for tracking purposes.

By the way, I noticed that filter_env: [''] got me the expected behavior of filter_env: true. It's ugly, but it works.

@Unitech Unitech deleted the branch Unitech:development February 17, 2022 09:13
@Unitech Unitech closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants