-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisions for dev branch #838
Conversation
merge dev-branch from Unitech/PM2
…gnoreWatch` to `ignore_watch`
…efness and easy configuration. 2. Refactor start/restart
Renamed |
Everything goes fine now, sorry about the untidy commits ;) Changes:
|
I'll review this as soon as I can @Tjatse looks awesome! |
@soyuka Thats great, thx! |
@@ -507,6 +505,7 @@ commander.command('ilogs') | |||
commander.command('kill') | |||
.description('kill daemon') | |||
.action(failOnUnknown(function(arg) { | |||
console.log('kill') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, MISTAKE, forgot to remove!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I'm here for (:
Awesome PR, thanks! I'm reviewing it |
I made some correction to the code: allow array and string for watch option -- add some tests for JSON validation homogeneize option parsing logic between JSON and CLI execution - cancel JSON execution if there are errors - cleanly exit PM2 CLI with exitCli() State ERRORED_STATUS like stopped/stopping - calling reloadProcessId restart app if stopped or not cluster_mode (fix pull&reload bug) - change exec logic order - flattify Methods.backward Works well now! |
Great jobs 👍 Unity is strength :p You guys rock!! |
Reload
env
graceful and peacefulUnify
appConf
- renameignoreWatch
toignore_watch
Documents of Schema
CLI
ignore_watch
supportsValidate Commander options and JSON key-values
Divide String to Array more intelligence (ESC supports)
The
nodeArgs
will beBut not
Make options briefness and easy configuration
min_uptime
Value of
min_uptime
could be:e.g.
"min_uptime": 3000
means 3000 milliseconds.In the meantime we are making it briefness and easy configuration:
h
,m
ands
, e.g.:"min_uptime": "1h"
means one hour,"min_uptime": "5m"
means five minutes and"min_uptime": "10s"
means ten seconds (At last, it will be transformed into milliseconds).max_memory_restart
Value of
max_memory_restart
could be:e.g.
"max_memory_restart": 1024
means 1024 bytes (NOT BITS).In the meantime we are making it briefness and easy configuration:
G
,M
andK
, e.g.:"max_memory_restart": "1G"
means one gigabytes,"max_memory_restart": "5M"
means five megabytes and"max_memory_restart": "10K"
means ten kilobytes (At last, it will be transformed into byte(s)).Refactor start/restart/reload (CLI, JSON), auto inspect configurations by configured schema, more output information, more humanity.