Allow env vars per each ecosystem's deploy #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 27, 2014 12:44
| app.env = app.env || {}; | ||
|
|
||
| // First merge variables from deploy.production.env object as least priority. | ||
| if (deployConf && deployConf[envName] && deployConf[envName]['env']) { |
There was a problem hiding this comment.
envName should be checked here too, e.g.:
if (envName && deployConf && ...)
|
I should have changed docs. What do you guys think? |
|
Docs improvements are always good, if you think that it's missing something feel free to add it ;) |
…est is app.env_dev. Update docs. Update sample ecosystem.json when doing `pm2 ecosystem`.
|
Docs updates. Feel free to merge or tell me what you think. :) |
Unitech
added a commit
that referenced
this pull request
Nov 28, 2014
Allow env vars per each ecosystem's deploy
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Unitech/pm2-deploy#29 ( and #748 )