Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed critical bug: process.env flattens all env-vars. #898

Merged
merged 2 commits into from
Dec 23, 2014
Merged

fixed critical bug: process.env flattens all env-vars. #898

merged 2 commits into from
Dec 23, 2014

Conversation

Tjatse
Copy link
Collaborator

@Tjatse Tjatse commented Dec 23, 2014

Cluster clients can not receive deep-level objects or arrays in the forked process, e.g.:

{
  "args": [
    "foo",
    "bar"
  ], 
  "env": { 
    "foo1": "bar1" 
  }
} 

will be parsed to

{
  "args": "foo, bar", 
  "env": "[object Object]"
}

Actually it's a process.env problem.
#896

@Tjatse Tjatse added the invalid label Dec 23, 2014
@Tjatse Tjatse removed the invalid label Dec 23, 2014
Tjatse added a commit that referenced this pull request Dec 23, 2014
fixed critical bug: `process.env` flattens all env-vars.
@Tjatse Tjatse merged commit 16682f1 into Unitech:master Dec 23, 2014
@rangercyh
Copy link

what about forkmode, it just work wrong as before
"env": {
"type": "conn",
"id": "conn-1",
"host": "10.20.127.197",
"clientPort": 5000,
"router": 3000
}

in the process,I print the process.env
env: '[object Object]',
how can I figure it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants