Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin startup script #936

Merged
merged 3 commits into from Jan 15, 2015
Merged

Darwin startup script #936

merged 3 commits into from Jan 15, 2015

Conversation

Tjatse
Copy link
Collaborator

@Tjatse Tjatse commented Jan 13, 2015

Base on launchd(8)

Tested on

  • OS X 10.8.5
  • OS X 10.9.4

Need more tests.

@soyuka
Copy link
Collaborator

soyuka commented Jan 13, 2015

#791

Looks nice!

@Tjatse
Copy link
Collaborator Author

Tjatse commented Jan 13, 2015

@soyuka I remember that you are having the Darwin environment, can you pull the repo and make a simple test? hah

localhost:PM2-Tjatse $ bin/pm2 kill
localhost:PM2-Tjatse $ bin/pm2 start test/fixtures/server.js
localhost:PM2-Tjatse $ bin/pm2 start test/fixtures/signal.js
localhost:PM2-Tjatse $ sudo bin/pm2 startup -u soyuka
# reboot

@soyuka
Copy link
Collaborator

soyuka commented Jan 13, 2015

I'm not @ home right now, I'd be able to test tonight and let you now :).

@Tjatse
Copy link
Collaborator Author

Tjatse commented Jan 13, 2015

@soyuka 👍

@soyuka
Copy link
Collaborator

soyuka commented Jan 14, 2015

Had to npm link* but it's working perfectly fine :).

*pm2 dump => pm2 command not found with an error message about the startup choice. After linking it went smoothly!

@Tjatse
Copy link
Collaborator Author

Tjatse commented Jan 14, 2015

@soyuka Just forgot to mention that in the test script. :p

@soyuka
Copy link
Collaborator

soyuka commented Jan 14, 2015

np, it's just that the https://github.com/Tjatse/PM2/blob/618e2da660e64d171b5d021dc40c434b96e88aa4/lib/CLI.js#L426 error message does not reflect the same error ^^. Nevermind, this will not happend with a global installed pm2 :).

I think you can merge this + close #791, thanks!

@Tjatse
Copy link
Collaborator Author

Tjatse commented Jan 14, 2015

@soyuka Yup, Gotcha, you're running this on a pure env - removed official PM2, but I'm not. Haha.
If @Unitech has no objection, I am going to merge this.

Again, appreciate your help.

Tjatse added a commit that referenced this pull request Jan 15, 2015
@Tjatse Tjatse merged commit a007cd5 into Unitech:development Jan 15, 2015
@Tjatse Tjatse deleted the darwin-startup-script branch January 15, 2015 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants