[enhance] Process morphological mode in explore graph paths #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eradan94
changed the title
martinec
reviewed
Jun 26, 2019
Fst2List.cpp
Outdated
| @@ -269,6 +269,7 @@ class CFstApp { | |||
| char ofExt[16]; | |||
| char ofnameOnly[512]; // output file name | |||
| char defaultIgnoreName[512]; // input file name | |||
| bool modeMorph = false; // true if the current state is in morphological mode | |||
There was a problem hiding this comment.
Have you noticed this suggestion #82 (comment) ?
There was a problem hiding this comment.
Oops, i forgot this one. Done.
martinec
changed the title
martinec
requested changes
Jun 27, 2019
Fst2List.cpp
Outdated
| /** | ||
| * print one space when the morphological mode is off | ||
| **/ | ||
| void outOneSpace() { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think I misunderstood your comment. What changes should I make?
There was a problem hiding this comment.
What about appendSingleSpace instead of outOneSpace ?
There was a problem hiding this comment.
It seems better than outOneSpace
|
LGTM |
JM-ERI
pushed a commit
to JM-ERI/unitex-core
that referenced
this pull request
Aug 16, 2020
martinec
pushed a commit
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Process the morphological mode in explore graph paths.
Motivation and Context
Issue #80
How Has This Been Tested?
Tested with several graphs in French, Malagasy and Korean
Malagasy : V-tous.grf
French : see attachment and Dnum-ord.grf
Korean : tested with graphs given by Pr.Nam, but unsure about the jamo processing
tested-graphs.zip
Screenshots (if appropriate):
Type of files
bin: Binary filesci: Continuous integration filesdoc: Documentation filesLevel of change
break: Breaking changeexp: Experimental changetmp: Temporal changemajor: Major changeminor: Minor changesec: Vulnerability-related changeType of change
deprecat: Deprecation of a once-stable featureenhance: Enhancement in existing functionalityfix: Bug fixfeature: New featurehotfix: Hotfix for bugsrefactor: Improve coding style, commentsremove: Remove a featureChecklist: