Fixed output add button could become invisible #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
MarieGuff
approved these changes
Dec 21, 2021
VitaVFX
approved these changes
Dec 23, 2021
PaulDemeulenaere
approved these changes
Jan 4, 2022
julienf-unity
pushed a commit
that referenced
this pull request
Jan 13, 2022
* [Hack] Fixed output add button could become invisible This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position * Fixed an issue when there's no output category in the blackboard * Fixed formatting issue * Updated changelog
julienf-unity
pushed a commit
that referenced
this pull request
Jan 13, 2022
* [Hack] Fixed output add button could become invisible This can happen when the scrollview is too small and the horizontal scrollbar is not at the right most position * Fixed an issue when there's no output category in the blackboard * Fixed formatting issue * Updated changelog
julienamsellem
added
backported-2021.2
backported-2022.1
and removed
needs-backport-2021.2
needs-backport-2022.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1389927/
In a VFX subgraph, the output add button (+) in the blackboard can become invisible when the output category has a visible scrollbar.
[Before]
[After]
Testing status
Comments to reviewers
The original issue is rather in the scope of GraphView because the same issue happens in ShaderGraph.
But since there's no more development on GraphView I fixed it specifically for VFX (the fix is a hack ...)